refactor: port channel, channel-parameter and schema models #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
fmvilas,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
smoya
approved these changes
May 9, 2022
There was a problem hiding this comment.
LGTM!
However, not sure if you want to wait for asyncapi/parser-api#64 (comment) to conclude so you can add the missing methods here or rather merge this and create a PR later.
|
@smoya Don't worry, if Fran/Jonas reply to our thoughts I will update my PR and add also the missing methods from this PR :) Thanks for review! |
|
/rtm |
magicmatatjahu
added a commit
to magicmatatjahu/parser-js
that referenced
this pull request
Oct 3, 2022
derberg
pushed a commit
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port
Channel,Channel-parameterandSchemamodels.Related issue(s)
Part of #481
Part of #482